Differential D22461

Add missing QVector include
ClosedPublic
Actions

Authored by nicolasfella on Jul 14 2019, 10:09 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Ark
Commits
R36:dfad7a3f389c: Add missing QVector include
Summary

My build was failing with

In file included from /home/nico/kde/src/ark/kerfuffle/pluginmanager.cpp:28:
/home/nico/kde/src/ark/kerfuffle/pluginmanager.h:138:22: error: field ‘m_plugins’ has incomplete type ‘QVector<Kerfuffle::Plugin*>’
     QVector<Plugin*> m_plugins;
                      ^~~~~~~~~
In file included from /usr/include/qt/QtCore/qglobal.h:1204,
                 from /usr/include/qt/QtCore/qnamespace.h:43,
                 from /usr/include/qt/QtCore/qobjectdefs.h:48,
                 from /usr/include/qt/QtCore/qobject.h:46,
                 from /usr/include/qt/QtCore/QObject:1,
                 from /home/nico/kde/src/ark/kerfuffle/plugin.h:33,
                 from /home/nico/kde/src/ark/kerfuffle/pluginmanager.h:31,
                 from /home/nico/kde/src/ark/kerfuffle/pluginmanager.cpp:28
Test Plan

Builds. Can open a file

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jul 14 2019, 10:09 PM
Restricted Application added a project: Ark. · View Herald TranscriptJul 14 2019, 10:09 PM
Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jul 14 2019, 10:09 PM
nicolasfella edited the summary of this revision. (Show Details)Jul 14 2019, 10:11 PM
nicolasfella edited the test plan for this revision. (Show Details)
nicolasfella added a reviewer: Ark.
elvisangelaccio accepted this revision.Jul 15 2019, 8:06 PM
This revision is now accepted and ready to land.Jul 15 2019, 8:06 PM
Closed by commit R36:dfad7a3f389c: Add missing QVector include (authored by nicolasfella). · Explain WhyJul 15 2019, 8:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkerfuffle/pluginmanager.h (1 line)

Diff 61829

View Options

kerfuffle/pluginmanager.h

Loading...