Differential D22415

Actually set minimum Qt version
ClosedPublic
Actions

Authored by wbauer on Jul 12 2019, 9:31 AM.

Details

Reviewers
chehrlic
Commits
R220:fc49e3ec5d80: Actually set minimum Qt version
Summary

Setting the variable QT_MIN_VERSION is not enough to enforce a minimum Qt version, the version needs
to be passed to the find_package call to have effect.

Test Plan

Build fails in cmake now when trying to build with Qt 5.6.
Before, cmake succeeded, and it failed during compilation later.

Still builds fine with Qt 5.9 and 5.13.

Diff Detail

Repository
R220 Subversion Client (KDE SVN)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wbauer requested review of this revision.Jul 12 2019, 9:31 AM
wbauer created this revision.
wbauer edited the test plan for this revision. (Show Details)Jul 12 2019, 10:02 AM
chehrlic accepted this revision.Jul 12 2019, 1:47 PM

Thx, this was an oversight from Qt4 porting.

This revision is now accepted and ready to land.Jul 12 2019, 1:47 PM
Closed by commit R220:fc49e3ec5d80: Actually set minimum Qt version (authored by wbauer). · Explain WhyJul 12 2019, 2:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 61661

View Options

CMakeLists.txt

Loading...