Differential D2241

Remove dead code
ClosedPublic
Actions

Authored by davidedmundson on Jul 21 2016, 12:34 AM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R119:79f842066d05: Remove dead code
Summary

Setting the layout height to be the height of one of the layout items is
both pointless, it will be calculated from all child items
implicitHeight anyway, and wrong as the heading/textField could be
bigger.

CCBUG: 365295

Test Plan

Opened it, looked the same

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 5372.Jul 21 2016, 12:34 AM
davidedmundson retitled this revision from to Remove dead code.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 21 2016, 12:34 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin accepted this revision.Jul 21 2016, 8:37 AM
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.Jul 21 2016, 8:37 AM
Closed by commit R119:79f842066d05: Remove dead code (authored by davidedmundson). · Explain WhyAug 1 2016, 12:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5600

View Options

desktoppackage/contents/activitymanager/Heading.qml

Loading...