Differential D22403

qobject_cast rather than dynamic_cast
ClosedPublic
Actions

Authored by sitter on Jul 11 2019, 2:48 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R871:ec63673c3695: qobject_cast rather than dynamic_cast
Summary

doesn't require RTTI and is faster

(I am not sure why there are casts at all instead of pointer members...)

Test Plan

builds

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jul 11 2019, 2:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 11 2019, 2:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jul 11 2019, 2:48 PM
broulik accepted this revision.Jul 11 2019, 2:50 PM
broulik added a subscriber: broulik.
broulik added inline comments.
src/bugzillaintegration/reportassistantdialog.cpp
285

Why does it check for page here but not down below? (Unrelated question to this patch)

This revision is now accepted and ready to land.Jul 11 2019, 2:50 PM
sitter added inline comments.Jul 11 2019, 2:59 PM
src/bugzillaintegration/reportassistantdialog.cpp
285

the entire class is a hot mess WRT pointer management I think

Closed by commit R871:ec63673c3695: qobject_cast rather than dynamic_cast (authored by sitter). · Explain WhyJul 12 2019, 12:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 61649

View Options

src/bugzillaintegration/reportassistantdialog.cpp

Loading...