Differential D22402

only benchmark once
ClosedPublic
Actions

Authored by sitter on Jul 11 2019, 2:34 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R871:854c95323993: only benchmark once
Summary

benchmarking N times slows down the test considerably for what feels like
zero testing advantage. getting just some rough benchmark data should
be entirely sufficient for a unit test. when more detailed
benchmarking is required one can easily switch the benchmark macro

Test Plan

6 times faster test pass

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jul 11 2019, 2:34 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 11 2019, 2:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jul 11 2019, 2:34 PM
apol accepted this revision.Jul 11 2019, 6:39 PM
This revision is now accepted and ready to land.Jul 11 2019, 6:39 PM
Closed by commit R871:854c95323993: only benchmark once (authored by sitter). · Explain WhyJul 12 2019, 12:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 61653

View Options

src/tests/backtraceparsertest/backtraceparsertest.cpp

Loading...