Fix extraction when an archive has a percentage in the name
ClosedPublic
Actions

Authored by elvisangelaccio on Jul 19 2016, 8:21 PM.

Details

Reviewers

Commits

R36:c98d64bfb517: Fix extraction when an archive has a percentage in the name

Summary

If an archive's filename has a percentage character (%), QUrl::toDisplayString() results in a QString containing %25 instead of %,
breaking a lot of stuff. Porting to QUrl::toLocalFile() fixes this issue (bug 365798).

A similar fix should be applied also to AddToArchive jobs.

Test Plan

BatchExtract job is unit tested.

Normal extraction to a subfolder with percentage in the name also work as
expected.

Diff Detail

Repository

R36 Ark

Branch

tests/batchextract

Lint

No Linters Available

Unit

No Unit Test Coverage

elvisangelaccio updated this revision to Diff 5334.Jul 19 2016, 8:21 PM

elvisangelaccio retitled this revision from to Fix extraction when an archive has a percentage in the name.

elvisangelaccio updated this object.

elvisangelaccio edited the test plan for this revision. (Show Details)

elvisangelaccio added a reviewer: rthomsen.

Restricted Application added a project: Ark. · View Herald TranscriptJul 19 2016, 8:21 PM

Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript

elvisangelaccio updated this object.Jul 19 2016, 8:23 PM

elvisangelaccio updated this object.Jul 19 2016, 8:31 PM

elvisangelaccio mentioned this in D2230: Fix AddToArchive when filenames have a percentage character.Jul 19 2016, 9:01 PM

rthomsen added inline comments.Jul 20 2016, 9:34 AM

autotests/app/batchextracttest.cpp
80 ↗	(On Diff #5334)	Should we add QDir::Hidden here, in case we include test archives with hidden files in the future?

Add also QDir::Hidden

elvisangelaccio marked an inline comment as done.Jul 20 2016, 11:34 AM

Nice work! :)

This revision is now accepted and ready to land.Jul 20 2016, 4:26 PM

Closed by commit R36:c98d64bfb517: Fix extraction when an archive has a percentage in the name (authored by elvisangelaccio). · Explain WhyJul 21 2016, 10:16 AM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in R36:c98d64bfb517: Fix extraction when an archive has a percentage in the name.

Revision Contents
Changeset List

			Path
M			app/batchextract.cpp (6 lines)
M			autotests/CMakeLists.txt (1 line)
A	M		autotests/app/CMakeLists.txt (9 lines)
A	M		autotests/app/batchextracttest.cpp (94 lines)
A	M	(bin)	autotests/app/data/simple%archive.tar.gz
M			part/part.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5334	3283294		Jul 19 2016, 8:21 PM	★	★
Diff 2	5348	3283294	- Add also `QDir::Hidden`	Jul 20 2016, 11:32 AM	★	★
Diff 3	5378	bf2de67	rARKc98d64bfb5176d03f37ae5bed9b1fe8d9d5bbbc2	Jul 21 2016, 10:11 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
666d74ad35d3	9125f061ee4c	0abdd2fc25bf	Elvis Angelaccio	Add also QDir::Hidden	Jul 20 2016, 11:32 AM
0abdd2fc25bf	53c0a3d3a5c2	126efc567b1f	Elvis Angelaccio	Fix extraction when an archive has a percentage in the name (Show More…)	Jul 19 2016, 8:13 PM
126efc567b1f	05fc73379668	b78c451a56e6	Elvis Angelaccio	Cleanup	Jul 19 2016, 7:57 PM
b78c451a56e6	5ae777b2bbfb	ef3ba5c42b34	Elvis Angelaccio	Use fromUserInput()	Jul 19 2016, 7:47 PM
ef3ba5c42b34	8b7206df5c11	31e990af082e	Elvis Angelaccio	Cleanup	Jul 19 2016, 7:19 PM
31e990af082e	e1061af9656f	3283294371d8	Elvis Angelaccio	Introduce test	Jul 19 2016, 5:41 PM