| tbaumgart |
| KMyMoney |
The color palette used for a diagram can now be modified in
individual reports.
Note: In KReportConfigurationFilterDlg::slotSearch there is redundant code
for casting eMyMoney::Report::ChartPalette to int which is already implemented
in xmlstoragehelper.cpp.
BUG:408361
FIXED-IN:4.8.4,5.0.6
compiled and checked on linux
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Unfortunally in 5.0 branch there is not reports entry in the settings dialog. This settings has been moved to settings->plugins->report-plugin->settings
On testing this patch it turned out that if an report uses application palette setting and the palette settings in the application is changed, the new palette is not applied on the fly. It is required to apply the report settings to see the change. This is not an issue with the 4.8 variant of this patch.
Note: this won't make it into 5.0.5 which is due in a few days and there is currently a string freeze. Since it looks like this change is adding strings, we should postpone it.
Looks OK to me, though I saw the following when applying the patch:
INFO Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D22293.
This diff is against commit 056dcbbb7c19f439d117ff2d0b5c1d92bf5fd30e, but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state? (634b25f32767258ba72b4fa3b5402a0260f4becd)
[Y/n] y
Checking patch kmymoney/plugins/xmlhelper/xmlstoragehelper.cpp...
Checking patch kmymoney/plugins/views/reports/reporttabimpl.cpp...
Checking patch kmymoney/plugins/views/reports/reporttabchart.ui...
Checking patch kmymoney/plugins/views/reports/kreportconfigurationfilterdlg.cpp...
Checking patch kmymoney/plugins/views/reports/kbalancechartdlg.cpp...
Checking patch kmymoney/plugins/views/reports/core/kreportchartview.cpp...
Checking patch kmymoney/mymoney/mymoneyreport_p.h...
Checking patch kmymoney/mymoney/mymoneyreport.h...
Checking patch kmymoney/mymoney/mymoneyreport.cpp...
Checking patch kmymoney/mymoney/mymoneyenums.h...
Applied patch kmymoney/plugins/xmlhelper/xmlstoragehelper.cpp cleanly.
Applied patch kmymoney/plugins/views/reports/reporttabimpl.cpp cleanly.
Applied patch kmymoney/plugins/views/reports/reporttabchart.ui cleanly.
Applied patch kmymoney/plugins/views/reports/kreportconfigurationfilterdlg.cpp cleanly.
Applied patch kmymoney/plugins/views/reports/kbalancechartdlg.cpp cleanly.
Applied patch kmymoney/plugins/views/reports/core/kreportchartview.cpp cleanly.
Applied patch kmymoney/mymoney/mymoneyreport_p.h cleanly.
Applied patch kmymoney/mymoney/mymoneyreport.h cleanly.
Applied patch kmymoney/mymoney/mymoneyreport.cpp cleanly.
Applied patch kmymoney/mymoney/mymoneyenums.h cleanly.
OKAY Successfully committed patch.This diff is against commit 056dcbbb7c19f439d117ff2d0b5c1d92bf5fd30e, but the commit is nowhere in the working copy. Try to apply it against the current working copy state? (634b25f32767258ba72b4fa3b5402a0260f4becd) [Y/n] y
fixed by rebasing