hijack nextbutton on preview page and rename it to Submit!
ClosedPublic
Actions

Authored by sitter on Jul 5 2019, 11:02 AM.

Details

Reviewers

Group Reviewers

Plasma
VDG

Commits

R871:470549de27d8: hijack nextbutton on preview page and rename it to Submit!

Summary

it's very awkward when you don't know when a change happens or
not, so suitably label the next button so it actually says submit when
it will trigger the report submission.

CHANGELOG: Buttons are more suitably labled when bug reports are submitted

Test Plan

file bug report -> preview page has submit button -> going back it is not submit -> clicking submit it also turns back to next (albeit disabled)

Diff Detail

Repository

R871 DrKonqi

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

sitter created this revision.Jul 5 2019, 11:02 AM

Restricted Application added a project: Plasma. · View Herald TranscriptJul 5 2019, 11:02 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

sitter requested review of this revision.Jul 5 2019, 11:02 AM

Harbormaster completed remote builds in B13641: Diff 61205.Jul 5 2019, 11:02 AM

Looks comme ca:

ngraham accepted this revision.Jul 5 2019, 11:04 AM

This revision is now accepted and ready to land.Jul 5 2019, 11:04 AM

Closed by commit R871:470549de27d8: hijack nextbutton on preview page and rename it to Submit! (authored by sitter). · Explain WhyJul 5 2019, 2:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/bugzillaintegration/reportassistantdialog.h (7 lines)
M			src/bugzillaintegration/reportassistantdialog.cpp (16 lines)
M			src/bugzillaintegration/reportassistantpages_bugzilla.h (2 lines)
M			src/bugzillaintegration/reportassistantpages_bugzilla.cpp (7 lines)