Fix testing for encrypted archives
ClosedPublic

Authored by rthomsen on Jul 19 2016, 7:02 PM.

Details

Summary

We can enable testing for encrypted archives by passing the password switch to the cli programs. This is of course not possible for non-he archives, for which we disable the Test action.

Test Plan
  • Verify that the Test action works for password-protected archives with header-encryption.
  • Verify that the Test action is disabled for password-protected archives without header-encryption.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rthomsen updated this revision to Diff 5324.Jul 19 2016, 7:02 PM
rthomsen retitled this revision from to Fix testing for encrypted archives.
rthomsen updated this object.
rthomsen edited the test plan for this revision. (Show Details)
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to R36 Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptJul 19 2016, 7:02 PM
elvisangelaccio accepted this revision.Jul 19 2016, 7:37 PM
elvisangelaccio edited edge metadata.
elvisangelaccio added inline comments.
part/part.cpp
481 ↗(On Diff #5324)

Also add a tooltip explaining the reason for disabling, like we did for "Add Files"

This revision is now accepted and ready to land.Jul 19 2016, 7:37 PM
This revision was automatically updated to reflect the committed changes.