Differential D22271

Fix int overflow when parsing ImapSet
ClosedPublic
Actions

Authored by dvratil on Jul 4 2019, 1:54 PM.

Details

Reviewers
vkrause
Group Reviewers
KDE PIM
Commits
R177:8bc38d948c53: Fix int overflow when parsing ImapSet
Summary

The ImapSet is a vector of qint64s, but while iteraring over
the vector the code stored the value as an int, which could've
caused overflow if the Id was large enough, triggering the
Q_ASSERT below.

BUG: 409419
FIXED-IN: 5.11.3

Diff Detail

Repository
R177 PIM: KIMAP
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Jul 4 2019, 1:54 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 4 2019, 1:54 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dvratil requested review of this revision.Jul 4 2019, 1:54 PM
dvratil edited the summary of this revision. (Show Details)Jul 4 2019, 1:55 PM
vkrause accepted this revision.Jul 4 2019, 4:02 PM
This revision is now accepted and ready to land.Jul 4 2019, 4:02 PM
Closed by commit R177:8bc38d948c53: Fix int overflow when parsing ImapSet (authored by dvratil). · Explain WhyJul 7 2019, 4:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/imapset.cpp (4 lines)

Diff 61286

View Options

src/imapset.cpp

Loading...