Differential D2225

Jobs: drop direct connection
ClosedPublic
Actions

Authored by elvisangelaccio on Jul 19 2016, 4:38 PM.

Details

Reviewers
rthomsen
Maniphest Tasks
T2944: Drop Qt::DirectConnection in Job connections
Commits
R36:ead7a07ee145: Drop direct connection for finished signal
Summary

Rationale in T2944

Test Plan

Close Ark during a running job on a huge archives (both with cli-based and libarchive-based archives):

  • ListJob is ok
  • DeleteJob hangs (with libarchive), but it happens even with the direct connection (see bug 365870).
  • AddJob is "ok" but causes bug 365869 with libarchive plugin.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 5318.Jul 19 2016, 4:38 PM
elvisangelaccio retitled this revision from to Jobs: drop direct connection.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio set the repository for this revision to R36 Ark.
elvisangelaccio added a project: Ark.
elvisangelaccio added a task: T2944: Drop Qt::DirectConnection in Job connections.
elvisangelaccio added a subscriber: kde-utils-devel.
rthomsen accepted this revision.Jul 19 2016, 6:23 PM
rthomsen edited edge metadata.

Ship it! :)

This revision is now accepted and ready to land.Jul 19 2016, 6:23 PM
Closed by commit R36:ead7a07ee145: Drop direct connection for finished signal (authored by elvisangelaccio). · Explain WhyJul 19 2016, 8:45 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:ead7a07ee145: Drop direct connection for finished signal.

Revision Contents
Changeset List

PathPackages
Mkerfuffle/jobs.cpp (2 lines)

Diff 5336

View Options

kerfuffle/jobs.cpp

Loading...