Differential D22246

Adapt to KCalCore::Attachment changes
ClosedPublic
Actions

Authored by vkrause on Jul 3 2019, 5:13 PM.

Details

Reviewers
dvratil
Commits
R75:f6cec5e2ed02: Adapt to KCalCore::Attachment changes

Diff Detail

Repository
R75 PIM: Calendar Support
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13615
Build 13633: arc lint + arc unit
vkrause created this revision.Jul 3 2019, 5:13 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 3 2019, 5:13 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Jul 3 2019, 5:13 PM
dvratil requested changes to this revision.Jul 3 2019, 7:25 PM
dvratil added a subscriber: dvratil.
dvratil added inline comments.
src/attachmenthandler.cpp
83–84

Indentation

126–127

Indentation

src/attachmenthandler.h
65–66

Fix indentation (below as well)

src/incidenceattachmentmodel.cpp
191

Make it const

This revision now requires changes to proceed.Jul 3 2019, 7:25 PM
vkrause updated this revision to Diff 61153.Jul 4 2019, 4:09 PM

apply review feedback

vkrause updated this revision to Diff 61157.Jul 4 2019, 4:33 PM

adapt to Attachment default ctor being explicit

dvratil accepted this revision.Jul 7 2019, 4:50 PM
This revision is now accepted and ready to land.Jul 7 2019, 4:50 PM
Closed by commit R75:f6cec5e2ed02: Adapt to KCalCore::Attachment changes (authored by vkrause). · Explain WhyJul 8 2019, 5:10 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 61157

View Options

src/attachmenthandler.h

Loading...
View Options

src/attachmenthandler.cpp

Loading...
View Options

src/incidenceattachmentmodel.cpp

Loading...