Differential D22222

Avoid an attachment pointer hash
ClosedPublic
Actions

Authored by vkrause on Jul 2 2019, 8:01 PM.

Details

Reviewers
mlaurent
Commits
R78:7246a7541694: Avoid an attachment pointer hash
Summary

Relying on this being a pointer prevents turning Attachment into an
implicitly shared value type.

Diff Detail

Repository
R78 PIM: Incidence Editor
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13537
Build 13555: arc lint + arc unit
vkrause created this revision.Jul 2 2019, 8:01 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 2 2019, 8:01 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Jul 2 2019, 8:01 PM
mlaurent accepted this revision.Jul 3 2019, 4:52 AM
This revision is now accepted and ready to land.Jul 3 2019, 4:52 AM
Closed by commit R78:7246a7541694: Avoid an attachment pointer hash (authored by vkrause). · Explain WhyJul 3 2019, 4:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 61034

View Options

src/attachmenticonview.h

Loading...
View Options

src/attachmenticonview.cpp

Loading...
View Options

src/incidenceattachment.cpp

Loading...