If a column is deleted the combobox in the curve dock shows again the name of the column, but is marked red. So the user knows the column has removed, but if a column with the same name is created/imported it will connected to the curve.
Details
Diff Detail
- Repository
- R262 LabPlot
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/CMakeLists.txt | ||
---|---|---|
185 ↗ | (On Diff #60963) | indentation. |
src/backend/core/AspectTreeModel.cpp | ||
197 ↗ | (On Diff #60963) | what is the advantage of moving this code to Column? I don't think the code is more compact now because of this change and you also need to implement the function in AbstractSimpleFilter. |
src/backend/core/ColumnObserver.cpp | ||
25 ↗ | (On Diff #60963) | if we don't need this function now, let's remove it. We can add it once we really need it. |
src/backend/core/Project.cpp | ||
208 | no brackets here. | |
220 | no brackets here. | |
225 | doesn't have any affect. Can be also removed I guess. | |
227 | no brackets for one-liners. | |
src/kdefrontend/dockwidgets/XYCurveDock.cpp | ||
507 | i18n("The column %1 is not available anymore. It will be automatically used once it is created again", m_curve->xColumnPath()) |
src/backend/core/Project.cpp | ||
---|---|---|
202 | move this comment inside the function definition. This is the comment for the handling of columns only and not for the whole function which does a bit more. | |
221 | in this for loop we call several set-functions which will produce a new entry on the undo/redo-stack. Do we want to have these entries if we change the name of a column? I'd say no. Le's work with curve->setUndoAware(false); | |
276 | same here. Let's use setUndoAware(false) prior to setting the columns. | |
src/backend/core/Project.h | ||
37 | can be removed. | |
src/kdefrontend/dockwidgets/XYCurveDock.cpp | ||
556 | wouldn't it be easier here to provide the column and the column path directly to this function like checkCurveAvailability(cbXColumn, curve->xColumn(), curve->xColumnPath()); With this you'd avoid this cumbersome if-else logic in XYCurveDock::checkCurveAvailability(). |