Differential D22192

remove foreach
ClosedPublic
Actions

Authored by astippich on Jul 1 2019, 4:31 PM.

Tags

Subscribers

Details

Reviewers

Commits

R824:c65f5d9cb05e: remove foreach

Diff Detail

Repository

R824 Baloo Widgets

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

astippich created this revision.Jul 1 2019, 4:31 PM

Restricted Application added a project: Baloo. · View Herald TranscriptJul 1 2019, 4:31 PM

Restricted Application added a subscriber: Baloo. · View Herald Transcript

astippich requested review of this revision.Jul 1 2019, 4:31 PM

Harbormaster completed remote builds in B13475: Diff 60940.Jul 1 2019, 4:31 PM

bruns added inline comments.Jul 5 2019, 8:08 PM

src/kblocklayout.cpp
175	Nitpick: `QLayoutItem* item` (space after *)
191	dito
245	likewise

code style

Harbormaster completed remote builds in B13677: Diff 61278.Jul 7 2019, 2:15 PM

bruns added inline comments.Jul 7 2019, 4:22 PM

src/kblocklayout.cpp
245	extraneous space between `))`
252	dito

remove extra space

Harbormaster completed remote builds in B13681: Diff 61287.Jul 7 2019, 4:48 PM

bruns accepted this revision.Jul 7 2019, 4:56 PM

This revision is now accepted and ready to land.Jul 7 2019, 4:56 PM

Closed by commit R824:c65f5d9cb05e: remove foreach (authored by astippich). · Explain WhyJul 7 2019, 5:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			src/filemetadataprovider.cpp (8 lines)
M			src/filemetadatawidget.cpp (6 lines)
M			src/kblocklayout.cpp (10 lines)
M			src/tagwidget.cpp (2 lines)
M			test/metadataconfigwidgetapp.cpp (4 lines)

Diff 61291

CMakeLists.txt

Loading...

src/filemetadataprovider.cpp

Loading...

src/filemetadatawidget.cpp

Loading...

src/kblocklayout.cpp

Loading...

src/tagwidget.cpp

Loading...

test/metadataconfigwidgetapp.cpp

Loading...