Differential D22068

Send downloads when downloads plugin is loaded
ClosedPublic
Actions

Authored by broulik on Jun 24 2019, 9:12 AM.

Details

Reviewers
fvogt
Group Reviewers
Plasma
Commits
R856:76d4b765f4f1: Send downloads when downloads plugin is loaded
Summary

We call sendDownloads() immediately when connecting to the port which looks racy.
Instead, have the plugin tell the extension to send all downloads once it is loaded and ready to accept input.
Kept the old call for compat which shouldn't hurt...

Test Plan

Started a download, reloaded the extension, reliably got a download created again

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 24 2019, 9:12 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 24 2019, 9:12 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 24 2019, 9:12 AM
broulik added a comment.Jun 24 2019, 10:44 AM

Or maybe I should remove the old code since the change to "update existing job when being signalled a creation" was only added in May

fvogt accepted this revision.Jul 2 2019, 7:14 AM
This revision is now accepted and ready to land.Jul 2 2019, 7:14 AM
Closed by commit R856:76d4b765f4f1: Send downloads when downloads plugin is loaded (authored by broulik). · Explain WhyJul 2 2019, 7:19 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 60984