[Notifications] Don't keep non-configurable notifications in history
ClosedPublic

Authored by broulik on Sun, Jun 23, 2:53 PM.

Details

Summary

If a notification isn't configurable (e.g. because the application doesn't set a desktop-entry hint), there's no way for the user to keep it out of the history if they so desire, causing excess history spam.

Test Plan
  • my vlc player and thunderbird no longer show up in the history which was 90% of pointless notifications I had in the history

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sun, Jun 23, 2:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Jun 23, 2:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sun, Jun 23, 2:53 PM
ngraham accepted this revision.Sun, Jun 23, 2:58 PM
ngraham added a subscriber: ngraham.

+1, if an app can't bother to set this stuff properly for itself, then it's either not very important or doesn't deserve to be in the history. Works perfectly.

This revision is now accepted and ready to land.Sun, Jun 23, 2:58 PM
This revision was automatically updated to reflect the committed changes.