Differential D2197

Fix adding subfolders to RAR archives
ClosedPublic
Actions

Authored by rthomsen on Jul 17 2016, 5:01 PM.

Details

Reviewers
elvisangelaccio
Commits
R36:ad31f89e60ec: Fix adding subfolders to RAR archives
Summary

Currently subfolders are not added to RAR archives. This was found to be due to a slash added to all directories in Part::slotAddFiles().

Fixes bug 365323.

Test Plan

Adding folders to RAR archives works as expected.
All unittests pass.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rthomsen updated this revision to Diff 5242.Jul 17 2016, 5:01 PM
rthomsen retitled this revision from to Fix adding subfolders to RAR archives.
rthomsen updated this object.
rthomsen edited the test plan for this revision. (Show Details)
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to R36 Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptJul 17 2016, 5:01 PM
elvisangelaccio accepted this revision.Jul 18 2016, 4:19 PM
elvisangelaccio edited edge metadata.

Ship it!

This revision is now accepted and ready to land.Jul 18 2016, 4:19 PM
Closed by commit R36:ad31f89e60ec: Fix adding subfolders to RAR archives (authored by rthomsen). · Explain WhyJul 18 2016, 4:46 PM
This revision was automatically updated to reflect the committed changes.
rthomsen mentioned this in R36:ad31f89e60ec: Fix adding subfolders to RAR archives.

Revision Contents
Changeset List

PathPackages
Mpart/part.cpp (15 lines)

Diff 5283

View Options

part/part.cpp

Loading...