We have no way to know the password after opening a non-he pwd-protected archive. If adding files, the new files will be unencrypted with no warning to the user.
This diff disables adding files to such an archive and shows a KMessageBox if the user tries to add files.
Open an existing pwd-protected non-he archive and activate the Add Files action.
| Lint Skipped |
| Unit Tests Skipped |
I'm not entirely convinced by this approach. What about disabling the action and explaining the reason in a tooltip?
Rationale: if the user sees the action is enabled, s/he expect something to happen when clicking on it. When instead a messagebox appears, s/he gets frustated because of the unexpected failure (and might not even read the error text).
Instead of showing a KMessageBox, we disable the "Add Files" action and provide an explanation in the tooltip.