Move the implementation of hasError and setHasError to iplugin. They are basically just getter/setters and actual implementation belong there - not in the individual plug-ins.
Unified the way plug-ins report errors when failing.
There is a separate patch for plug-ins in Kdevelop repository.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I'm not sure why you did it though...? Isn't it largely a matter of taste?
Where's the errorDescription being used?
| interfaces/iplugin.cpp | ||
|---|---|---|
| 198 | Would it make sense to limit the hasError to whether there's an errorDescription? The only advantage otherwise is to be able to have a failing plugin without a message. | |
Long story short: I did this patch in relation to some other work I was doing with regard to loading the plugins (I will post that as another review request when the fate of this has been decided.).
As such I agree: There is an element of taste in this patch. But I do think it brings some value to the code:
Where's the errorDescription being used?
The errorDescription is being used when we are trying to load a plugin and it for some reason fails. errorDescription will be written to the log.
| interfaces/iplugin.cpp | ||
|---|---|---|
| 200 | This should imply setHasError(true). | |
| interfaces/iplugin.h | ||
|---|---|---|
| 227 ↗ | (On Diff #5275) | /**
* Set a @p description of the error encountered. An empty error
* description implies no error in the plugin.
*/
void setErrorDescription(const QString &description); |