Move implementation of hasError and setHasError to iplugin
ClosedPublic
Actions

Authored by volden on Jul 16 2016, 2:32 PM.

Details

Reviewers

apol

Group Reviewers

KDevelop

Summary

This patch relies on differential D2192: Move implementation of hasError and setHasError to iplugin.

Adapt to the move of hasError and setHasError. Unify the way plugins report errors when failing .

Repository

R32 KDevelop

Lint

Lint Skipped

Unit

Unit Tests Skipped

volden retitled this revision from to Move implementation of hasError and setHasError to iplugin.

volden updated this object.

volden edited the test plan for this revision. (Show Details)

volden added a reviewer: KDevelop.

volden set the repository for this revision to R32 KDevelop.

volden added a subscriber: kdevelop-devel.

Kdevplatform patch has been updated. Updateing this patch as well to reflect Aleix review points.

apol added a reviewer: apol.

This revision is now accepted and ready to land.Jul 18 2016, 4:02 PM

Status here?

Hmm, this got pushed:

Git commit e2f3cbbf0ffb4413498e8a43abe5c0ac48bfa8ea by Morten Danielsen Volden.
Committed on 18/07/2016 at 21:04.
Pushed by volden into branch 'master'.

			Path	Packages
M			projectbuilders/ninjabuilder/kdevninjabuilderplugin.h (1 line)
M			projectbuilders/ninjabuilder/kdevninjabuilderplugin.cpp (10 lines)
M			projectmanagers/cmake/cmakedocumentation.h (3 lines)
M			projectmanagers/cmake/cmakedocumentation.cpp (11 lines)
M			projectmanagers/cmake/cmakemanager.h (3 lines)
M			projectmanagers/cmake/cmakemanager.cpp (13 lines)