Differential D21913

Modernize code
ClosedPublic
Actions

Authored by jbbgameich on Jun 19 2019, 6:11 PM.

Details

Reviewers
apol
Group Reviewers
Plasma: Mobile
Commits
R732:efabc0dc39d1: Modernize code
Summary
  • port away from Q_FOREACH
  • use override
Test Plan

Start the plasmaphonedialer or plasma-phonebook and check whether contacts are still being displayed.

Diff Detail

Repository
R732 KPeople VCard Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jbbgameich requested review of this revision.Jun 19 2019, 6:11 PM
jbbgameich created this revision.
apol added a subscriber: apol.Jun 20 2019, 10:42 AM

There's some explanation here: https://www.kdab.com/goodbye-q_foreach/

src/kpeoplevcard.cpp
65

will need to move the phoneNumbers in a separate const variable.

105–106

const

112

Needs qAsConst

jbbgameich updated this revision to Diff 60160.Jun 20 2019, 5:12 PM

More const

apol accepted this revision.Jun 20 2019, 11:30 PM
This revision is now accepted and ready to land.Jun 20 2019, 11:30 PM
Closed by commit R732:efabc0dc39d1: Modernize code (authored by jbbgameich). · Explain WhyJun 21 2019, 1:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kpeoplevcard.h (2 lines)
Msrc/kpeoplevcard.cpp (13 lines)

Diff 60238

View Options

src/kpeoplevcard.h

Loading...
View Options

src/kpeoplevcard.cpp

Loading...