Differential D21909

[Colors KCM] Assign properties in a binding
ClosedPublic
Actions

Authored by broulik on Jun 19 2019, 4:40 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R119:0b72df235a0a: [Colors KCM] Assign properties in a binding
Summary

Save the previous value in a variable outside the binding and then assign the new ones to ensure it updates automatically.

Test Plan

5.16

  • Changed colors to dark, filter icon on combobox turned white immediately

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 19 2019, 4:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 19 2019, 4:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 19 2019, 4:40 PM
ngraham accepted this revision.Jun 19 2019, 5:58 PM
This revision is now accepted and ready to land.Jun 19 2019, 5:58 PM
Closed by commit R119:0b72df235a0a: [Colors KCM] Assign properties in a binding (authored by broulik). · Explain WhyJun 20 2019, 12:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 60114

View Options

kcms/colors/package/contents/ui/main.qml

Loading...