Differential D21890

Simplify KSplash
ClosedPublic
Actions

Authored by davidedmundson on Jun 18 2019, 10:10 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R120:5bc35571901c: Simplify KSplash
Summary

Forking and printing a PID gains nothing.

The new startplasma script tracks the process used to start ksplash
itself.

BUG: 380495

Test Plan

Logged in, saw a splash
Ran the test from systemsettings, saw a splash

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 18 2019, 10:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jun 18 2019, 10:10 PM
apol accepted this revision.Jun 18 2019, 11:16 PM
apol added a subscriber: apol.
apol added inline comments.
ksplash/ksplashqml/main.cpp
51 ↗(On Diff #60032)

Maybe this wouldn't be necessary either, we can use normal logging/output.

This revision is now accepted and ready to land.Jun 18 2019, 11:16 PM
Closed by commit R120:5bc35571901c: Simplify KSplash (authored by davidedmundson). · Explain WhyJun 19 2019, 8:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mksplash/ksplashqml/main.cpp (30 lines)

Diff 60046

View Options

ksplash/ksplashqml/main.cpp

Loading...