Differential D21849

Fixes crash when copying hotspot
ClosedPublic
Actions

Authored by hallas on Jun 16 2019, 3:30 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:2562c3a003f6: Fixes crash when copying hotspot
Summary

Fixes crash when copying hotspot. It is caused by the code would remove
any actions from the hotspot after the context menu had executed, but
these actions have now been freed because the hotspot is freed (this was
done in 7265be97a2e9d84c4e036d426ffb0085710d9361 to fix a memory leak).

Test Plan

echo https://kde.org/
edit->find
type kde in the search box
select kde.org
right click and click copy

BUG: 408603

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hallas created this revision.Jun 16 2019, 3:30 PM
Restricted Application added a project: Konsole. · View Herald TranscriptJun 16 2019, 3:30 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
hallas requested review of this revision.Jun 16 2019, 3:30 PM
hindenburg accepted this revision.Jun 17 2019, 12:44 AM
This revision is now accepted and ready to land.Jun 17 2019, 12:44 AM
Closed by commit R319:2562c3a003f6: Fixes crash when copying hotspot (authored by hallas, committed by hindenburg). · Explain WhyJun 17 2019, 12:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/SessionController.cpp (9 lines)

Diff 59970

View Options

src/SessionController.cpp

Loading...