Refactor usage of class FileMetaData
ClosedPublic
Actions

Authored by aspotashev on Jun 15 2019, 10:15 PM.

Details

Reviewers

sdepiets
aacid

Commits

Summary

projectmodel: Convert enum ProjectModelColumns to enum class

Add unit test case for ProjectModel

projectmodeltest: Add test case with half-translated .po file

projectmodel: Delete unused ctors of ProjectNode

Reuse FileMetaData in class ProjectModel::ProjectNode

Repository

R456 Lokalize

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

aspotashev requested review of this revision.Jun 15 2019, 10:15 PM

aspotashev created this revision.

Great thanks

This revision is now accepted and ready to land.Jun 16 2019, 4:21 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/project/projectmodel.h (39 lines)
M			src/project/projectmodel.cpp (93 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	59894	ca377e8		Jun 15 2019, 10:15 PM	★	★
Diff 2	59906	e6cd696	R456:16049a46d1bd52d230d802470daaaadb8181c252	Jun 16 2019, 10:44 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
048b1944fadb	ca73c415da72	306a45a8e138	Alexander Potashev	Reuse FileMetaData in class ProjectModel::ProjectNode	Jun 13 2019, 3:21 PM
306a45a8e138	29c15a4e5417	912c4529e95d	Alexander Potashev	projectmodel: Delete unused ctors of ProjectNode	Jun 13 2019, 2:50 PM
912c4529e95d	a18ff780b655	405390aed72e	Alexander Potashev	projectmodeltest: Add test case with half-translated .po file	Jun 13 2019, 5:59 AM
405390aed72e	93725b465e23	1998517d17d1	Alexander Potashev	Add unit test case for ProjectModel	Jun 13 2019, 5:35 AM
1998517d17d1	1bc76d9cb559	ca377e8fc229	Alexander Potashev	projectmodel: Convert enum ProjectModelColumns to enum class	Jun 13 2019, 4:04 AM