Cleanup MIDebugger output signals
ClosedPublic

Authored by qi437103 on Jul 14 2016, 7:34 PM.

Details

Summary

There are 4 signals used for various output from the debugger:

  • applicationOutput: emitted when got stream record from the 'target' channel
  • userCommandOutput: emitted when got stream record from the 'console' channel and it's a user command
  • internalCommandOutput: emitted when got stream record from the 'console' channel and it's not a user command
  • internalOutput: emitted when got stream record from the 'log' channel or stderr from the debugger

And there are 2 output toolviews when debugging.

  • The normal Debug Output panel controled by MIDebugJob
    • Shows applicationOutput, via MIDebugSession::inferiorOutputLines
    • Shows internalCommandOutput, via MIDebugSession::debuggerInternalCommandOutput
  • The GDBOutputWidget which is part of the GDB plugin
    • Shows userCommandOutput, via MIDebugSession::debuggerUserCommandOutput
    • Shows internalCommandOutput, via MIDebugSession::debuggerInternalCommandOutput
    • Shows internalOutput, via MIDebugSession::debuggerInternalOutput

This should match the old behavior for toolviews and fixes the testStdOut unit test.

Test Plan

gdb unit tests

Diff Detail

Repository
R32 KDevelop
Branch
cleanup-dbgoutput-signal
Lint
No Linters Available
Unit
No Unit Test Coverage
qi437103 updated this revision to Diff 5177.Jul 14 2016, 7:34 PM
qi437103 retitled this revision from to Cleanup MIDebugger output signals.
qi437103 updated this object.
qi437103 edited the test plan for this revision. (Show Details)
qi437103 added a reviewer: apol.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJul 14 2016, 7:34 PM
apol accepted this revision.Jul 14 2016, 10:16 PM
apol edited edge metadata.
This revision is now accepted and ready to land.Jul 14 2016, 10:16 PM
This revision was automatically updated to reflect the committed changes.