Cleanup MIDebugger output signals
ClosedPublic
Actions

Authored by qi437103 on Jul 14 2016, 7:34 PM.

Details

Reviewers

apol

Group Reviewers

KDevelop

Commits

R32:6d7a4cfed42b: Cleanup MIDebugger output signals

Summary

There are 4 signals used for various output from the debugger:

applicationOutput: emitted when got stream record from the 'target' channel
userCommandOutput: emitted when got stream record from the 'console' channel and it's a user command
internalCommandOutput: emitted when got stream record from the 'console' channel and it's not a user command
internalOutput: emitted when got stream record from the 'log' channel or stderr from the debugger

And there are 2 output toolviews when debugging.

The normal Debug Output panel controled by MIDebugJob
- Shows applicationOutput, via MIDebugSession::inferiorOutputLines
- Shows internalCommandOutput, via MIDebugSession::debuggerInternalCommandOutput
The GDBOutputWidget which is part of the GDB plugin
- Shows userCommandOutput, via MIDebugSession::debuggerUserCommandOutput
- Shows internalCommandOutput, via MIDebugSession::debuggerInternalCommandOutput
- Shows internalOutput, via MIDebugSession::debuggerInternalOutput

This should match the old behavior for toolviews and fixes the testStdOut unit test.

Test Plan

gdb unit tests

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

qi437103 retitled this revision from to Cleanup MIDebugger output signals.

qi437103 updated this object.

qi437103 edited the test plan for this revision. (Show Details)

qi437103 added a reviewer: apol.

apol edited edge metadata.

This revision is now accepted and ready to land.Jul 14 2016, 10:16 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			debuggers/common/midebugger.h (7 lines)
M			debuggers/common/midebugger.cpp (11 lines)
M			debuggers/common/midebugjobs.cpp (6 lines)
M			debuggers/common/midebugsession.h (5 lines)
M			debuggers/common/midebugsession.cpp (1 line)
M			debuggers/gdb/gdboutputwidget.cpp (3 lines)