KSieve Session: fix race while handling SSL errors.
ClosedPublic

Authored by dfaure on Jul 14 2016, 12:18 PM.

Details

Summary

No need to post a request to the thread for handling an ignored ssl error,
which the thread will simply handle by emitting the sslDone signal,
which goes back to the main thread. By doing that we were making it possible
for the thread to emit other things meanwhile - like the received data from the server,
out of sequence (the main thread can only handle it after receiving sslDone)

This fixes the never-ending spinning in "Manage Sieve Scripts" in kmail
for me (which happened about 20% of the time).

BUG: 232246

Test Plan

Manage Sieve Scripts in kmail, > 5 times.

Diff Detail

Repository
R91 PIM: Sieve Handling Library
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure updated this revision to Diff 5160.Jul 14 2016, 12:18 PM
dfaure retitled this revision from to KSieve Session: fix race while handling SSL errors..
dfaure updated this object.
dfaure edited the test plan for this revision. (Show Details)
dfaure added reviewers: dvratil, mlaurent.
dfaure added a subscriber: KDE PIM.
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 14 2016, 12:18 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
mlaurent accepted this revision.Jul 14 2016, 2:27 PM
mlaurent edited edge metadata.

Your analyze seems logic.
Ship it :)
Thanks.

This revision is now accepted and ready to land.Jul 14 2016, 2:27 PM
dfaure closed this revision.Jul 14 2016, 2:52 PM