Differential D21644

use errorString instead of errorText
ClosedPublic
Actions

Authored by sitter on Jun 7 2019, 11:10 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R871:c8f8b9d962eb: use errorString instead of errorText
Summary

the former is for user display, the latter is a sparse variant for
internal use. this results in nicer/useful error messages on errors

CCBUG: 405597
CHANGELOG: Error message when failing to save backtraces are more helpful.

Test Plan
  • error is a readable string with description instead of only a file path now

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jun 7 2019, 11:10 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 7 2019, 11:10 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jun 7 2019, 11:10 AM
broulik accepted this revision.Jun 7 2019, 12:04 PM
This revision is now accepted and ready to land.Jun 7 2019, 12:04 PM
Closed by commit R871:c8f8b9d962eb: use errorString instead of errorText (authored by sitter). · Explain WhyJun 7 2019, 1:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/drkonqi.cpp (2 lines)

Diff 59341

View Options

src/drkonqi.cpp

Loading...