Differential D2163

KSieve: add return in case we're waiting for more data for "quantity".
ClosedPublic
Actions

Authored by dfaure on Jul 14 2016, 11:00 AM.

Details

Reviewers
mlaurent
dvratil
Commits
R91:9bbf8a1dd9f3: KSieve: add return in case we're waiting for more data for "quantity".
Test Plan

None. I found this logic flaw by reading the code. Makes no different in my testing (because I always get all of the quantity data available at once), but maybe it helps with bug 328246?

Diff Detail

Repository
R91 PIM: Sieve Handling Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure updated this revision to Diff 5150.Jul 14 2016, 11:00 AM
dfaure retitled this revision from to KSieve: add return in case we're waiting for more data for "quantity"..
dfaure updated this object.
dfaure edited the test plan for this revision. (Show Details)
dfaure added a reviewer: dvratil.
dfaure added a subscriber: KDE PIM.
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 14 2016, 11:00 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dfaure edited the test plan for this revision. (Show Details)Jul 14 2016, 11:11 AM
mlaurent added a subscriber: mlaurent.Jul 14 2016, 12:26 PM

Seems logic.
Ship it. For this 328246 it already fixed.
Regards

mlaurent accepted this revision.Jul 14 2016, 12:27 PM
mlaurent added a reviewer: mlaurent.
This revision is now accepted and ready to land.Jul 14 2016, 12:27 PM
Closed by commit R91:9bbf8a1dd9f3: KSieve: add return in case we're waiting for more data for "quantity". (authored by dfaure). · Explain WhyJul 14 2016, 10:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kmanagesieve/sessionthread.cpp (2 lines)

Diff 5190

View Options

src/kmanagesieve/sessionthread.cpp

Loading...