MessageViewer plugin: create EventEdit widget on demand.
ClosedPublic

Authored by dfaure on Jul 14 2016, 9:54 AM.

Details

Summary

This avoids creating a CollectionComboBox on startup (which includes a Monitor,
an ETM and 3 proxies on top), which might never be used if the user doesn't
use the "create event" feature.

The same change should of course be done to noteedit and todoedit.

The unittest had to be adjusted because it was checking that the widget
was created upfront and hidden, which is exactly what this patch changes.

Test Plan

Ctrl+E in kmail still brings up the event edit widget,
without any noticeable delay the first time.

Diff Detail

Repository
R81 KDE PIM Addons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure updated this revision to Diff 5146.Jul 14 2016, 9:54 AM
dfaure retitled this revision from to MessageViewer plugin: create EventEdit widget on demand..
dfaure updated this object.
dfaure edited the test plan for this revision. (Show Details)
dfaure added a reviewer: mlaurent.
dfaure added a subscriber: KDE PIM.
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 14 2016, 9:54 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
mlaurent added inline comments.Jul 14 2016, 12:22 PM
plugins/messageviewerplugins/createeventplugin/viewerplugincreateeventinterface.cpp
34

I prefer Q_NULLPTR as we use it in all kdepim.

knauss accepted this revision.Jul 14 2016, 12:22 PM
knauss added a reviewer: knauss.
knauss added a subscriber: knauss.

looks fine

This revision is now accepted and ready to land.Jul 14 2016, 12:22 PM
mlaurent accepted this revision.Jul 14 2016, 12:23 PM
mlaurent edited edge metadata.

Seems ok otherwise.
Thanks

dfaure closed this revision.Jul 14 2016, 1:01 PM