Differential D21557

[Media Controller] Anchor album art left and right as well
ClosedPublic
Actions

Authored by broulik on Jun 3 2019, 8:28 AM.

Details

Reviewers
filipf
Group Reviewers
Plasma
Commits
R120:0cd335211ad4: [Media Controller] Anchor album art left and right as well
Summary

Ensures it doesn't overflow its bounding box. Shouldn't make a visual differences (save for the margin) as it is PreserveAspectFit

BUG: 408101
FIXED-IN: 5.16.0

Test Plan

Put media controller on desktop, started youtube video (which provides a 16:9 thumbnail through p-b-i), resized the plasmoid to weird sizes, didn't overflow anymore.
Still looked the same in systray popup

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 3 2019, 8:28 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 3 2019, 8:28 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 3 2019, 8:28 AM
filipf accepted this revision.Jun 3 2019, 8:42 AM
filipf added a subscriber: filipf.

Fixes it for me.

This revision is now accepted and ready to land.Jun 3 2019, 8:42 AM
Closed by commit R120:0cd335211ad4: [Media Controller] Anchor album art left and right as well (authored by broulik). · Explain WhyJun 3 2019, 8:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 59056

View Options

applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

Loading...