Differential D21549

mobile: ThumbnailsBase: Rename properties to avoid overriding final properties of Kirigami
ClosedPublic
Actions

Authored by jbbgameich on Jun 2 2019, 8:43 PM.

Details

Reviewers
ngraham
Group Reviewers
Okular
Commits
R223:3a380e162081: mobile: ThumbnailsBase: Rename properties to avoid overriding final properties…
Summary

Fixes displaying the Drawer

Test Plan

Drawer is visible

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jbbgameich created this revision.Jun 2 2019, 8:43 PM
Restricted Application added a project: Okular. · View Herald TranscriptJun 2 2019, 8:43 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
jbbgameich requested review of this revision.Jun 2 2019, 8:43 PM
ngraham added a subscriber: ngraham.Jun 3 2019, 2:46 PM

Does this also need to be renamed by anything that uses those properties?

jbbgameich added a comment.Jun 3 2019, 3:49 PM

I don't think those properties are currently used anywhere.

ngraham accepted this revision.Jun 3 2019, 3:58 PM

Confirmed.

This revision is now accepted and ready to land.Jun 3 2019, 3:58 PM
Closed by commit R223:3a380e162081: mobile: ThumbnailsBase: Rename properties to avoid overriding final properties… (authored by jbbgameich). · Explain WhyJun 3 2019, 3:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 59076

View Options

mobile/app/package/contents/ui/ThumbnailsBase.qml

Loading...