Make the icon applet use the same shadow settings as desktop icons
ClosedPublic
Actions

Authored by filipf on Jun 2 2019, 5:17 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

We changed the desktop shadows in 10278e79f116, but we also need to reflect this change in the Icon applet which renders its own label and shadows.

Test Plan

Before:

After:

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

filipf requested review of this revision.Jun 2 2019, 5:17 PM

Stable branch please!

This revision is now accepted and ready to land.Jun 2 2019, 5:18 PM

filipf edited the test plan for this revision. (Show Details)Jun 2 2019, 5:18 PM

filipf added a reviewer: VDG.

filipf edited the test plan for this revision. (Show Details)

This revision was automatically updated to reflect the committed changes.

Sorry for not using merge, can someone please update the wiki (https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22) or explain the case when landing on 2 stable branches because it wouldn't merge when I was doing step 2 for 5.16.

EDIT: I figured out what I was doing wrong, my bad!

In step 2, you need to merge 5.12. It asks you which branch you want to merge into the current one.

			Path	Packages
M			applets/icon/package/contents/ui/main.qml (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	59025	b059097		Jun 2 2019, 5:17 PM	★	★
Diff 2	59031	45388fa	R120:e2764c8e4a9505007268f4c7dc3efbdc00542a32	Jun 2 2019, 7:56 PM	★	★