Differential D2149

[platforms/fbdev] Handle error conditions more gracefully
ClosedPublic
Actions

Authored by graesslin on Jul 13 2016, 8:11 AM.

Details

Reviewers
bshah
Group Reviewers
Plasma on Wayland
KWin
Commits
R108:f0aeda073835: [platforms/fbdev] Handle error conditions more gracefully
Summary

So far if the framebuffer platform run into an error on initialization
it did not continue and caused the system to freeze. With this change
it properly emits the initFailed signal in all error conditions which
causes kwin_wayland to terminate. This is a much better situation than
just staying in a running, but frozen state.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 5114.Jul 13 2016, 8:11 AM
graesslin retitled this revision from to [platforms/fbdev] Handle error conditions more gracefully.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJul 13 2016, 8:11 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
bshah accepted this revision.Jul 13 2016, 8:15 AM
bshah added a reviewer: bshah.
bshah added a subscriber: bshah.
bshah added inline comments.
plugins/platforms/fbdev/fb_backend.cpp
102

Perhaps print warning here as well.

This revision is now accepted and ready to land.Jul 13 2016, 8:15 AM
graesslin added inline comments.Jul 13 2016, 8:16 AM
plugins/platforms/fbdev/fb_backend.cpp
102

The method initImageFormat already prints a warning.

Closed by commit R108:f0aeda073835: [platforms/fbdev] Handle error conditions more gracefully (authored by graesslin). · Explain WhyJul 14 2016, 11:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5156

View Options

plugins/platforms/fbdev/fb_backend.cpp

Loading...