Differential D21481

Don't notify about changing to the same state it was at
ClosedPublic
Actions

Authored by apol on May 29 2019, 2:19 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Commits
R242:52124c663e34: Don't notify about changing to the same state it was at
Summary

The object tracker was telling me it's notifying the same value it
already got, and reading the code it seems to be already notifying when it
actually changes.

Test Plan

tests pass, plasma runs fine.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.May 29 2019, 2:19 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 29 2019, 2:19 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.May 29 2019, 2:19 PM
apol added a reviewer: Plasma.May 29 2019, 2:20 PM
apol added a comment.Jun 12 2019, 11:04 PM

Been running it since and no replies, I'll land it.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2019, 11:05 PM
Closed by commit R242:52124c663e34: Don't notify about changing to the same state it was at (authored by apol). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 59699

View Options

src/plasma/private/containment_p.cpp

Loading...