src/controls/templates/private/ContextIcon.qml
29	does the context menu icon keeps morphing correctly with this?
src/controls/templates/private/PageRow.qml
326	why adding check over mainFlickable.currentItem ? doesn't guard anything

src/controls/templates/private/ContextIcon.qml
29	tested, definitely breaks morphing. the property binding should be set in the drawer itself (a bit difficult as is in a loader) rathen than in the component

why adding check over mainFlickable.currentItem ? doesn't guard anything

We don't want mainFlickable.currentItem.width to fail if mainFlickable.currentItem is null.

Address Marco's comment

Fix morphing, proper testing

mart edited edge metadata.

This revision is now accepted and ready to land.Jul 20 2016, 9:37 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/controls/OverlayDrawer.qml (5 lines)
M			src/controls/Page.qml (2 lines)
M			src/controls/templates/ApplicationHeader.qml (2 lines)
M			src/controls/templates/private/ContextIcon.qml (2 lines)
M			src/controls/templates/private/MenuIcon.qml (2 lines)
M			src/controls/templates/private/PageRow.qml (9 lines)
M			src/styles/Desktop/OverlayDrawer.qml (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5096	13aed68		Jul 12 2016, 1:41 PM	★	★
Diff 2	5344	a97688b	Address Marco's comment	Jul 20 2016, 9:20 AM	★	★
Diff 3	5345	a97688b	Fix morphing, proper testing	Jul 20 2016, 9:36 AM	★	★
Diff 4	5346	a97688b	rKIRIGAMI50b4b7b032a295234436bb62a9575a592c44bf57	Jul 20 2016, 9:28 AM	★	★