Use layouts for QDialogs to make KmPlot adopt the sizes
ClosedPublic

Authored by yurchor on May 27 2019, 1:45 PM.

Details

Summary

As it was pointed out "KDialog had its own layout, and when porting to QDialog, a layout needs to be added"

BUG: 407980

Test Plan
  1. Open KmPlot, choose "Catesian Plot".
  2. Enter something (e.g. "x^2").
  3. Click on the Equation Editor button at the right of the input field.
  4. Try to resize the window (all interface items are movable now).
  5. Press the Constant Editor button.
  6. Try to resize the window (all interface items are movable now).
  7. Close the windows.
  8. Try to choose any item from the "Tools" menu.
  9. Try to resize the window (all interface items should be movable).

Diff Detail

Repository
R334 KmPlot
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.May 27 2019, 1:45 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 27 2019, 1:45 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
yurchor requested review of this revision.May 27 2019, 1:45 PM
cfeck added a comment.May 27 2019, 7:51 PM

Merci.

ksliderwindow.cpp needs the same treatment.

cfeck added a comment.May 27 2019, 7:53 PM

Before I check the other dialogs, please see your original porting commit that I referenced at the bug. It should list all places where KDialog was ported to QDialog.

yurchor updated this revision to Diff 58745.May 28 2019, 4:04 AM

Treat the gradient dilog, slider window and parameter animator as well.

cfeck accepted this revision.May 28 2019, 9:13 AM
cfeck added inline comments.
kmplot/ksliderwindow.cpp
98–99

Fix trailing whitespace before pushing.

This revision is now accepted and ready to land.May 28 2019, 9:13 AM
yurchor updated this revision to Diff 58792.May 28 2019, 3:13 PM

Fix trailing whitespace

This revision was automatically updated to reflect the committed changes.