Differential D21384

Don't use QTimer::callOnTimeout
ClosedPublic
Actions

Authored by davidre on May 24 2019, 3:41 PM.

Details

Reviewers
ngraham
Group Reviewers
Spectacle
Commits
R166:bdbe5589a998: Don't use QTimer::callOnTimeout
Summary

it is just a convenience function for connect that was added in Qt 5.12. Currently the minimum we require is 5.10
so just use connect.

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.May 24 2019, 3:41 PM
Restricted Application added a project: Spectacle. · View Herald TranscriptMay 24 2019, 3:41 PM
davidre requested review of this revision.May 24 2019, 3:41 PM
ngraham accepted this revision.May 24 2019, 3:58 PM
ngraham added a subscriber: ngraham.

Good call

src/Gui/KSMainWindow.cpp
219–220

In general for readability, the preferred connect syntax is to put the 3rd and 4th arguments on a new line, like this:

connect(mHideMessageWidgetTimer, &QTimer::timeout,
        mMessageWidget, &KMessageWidget::animatedHide);
This revision is now accepted and ready to land.May 24 2019, 3:58 PM
davidre updated this revision to Diff 58616.May 24 2019, 5:28 PM
  • formatting
davidre marked an inline comment as done.May 24 2019, 5:29 PM
davidre added inline comments.
src/Gui/KSMainWindow.cpp
219–220

Thanks for the tip, makes sense.

Closed by commit R166:bdbe5589a998: Don't use QTimer::callOnTimeout (authored by davidre). · Explain WhyMay 24 2019, 5:30 PM
This revision was automatically updated to reflect the committed changes.
davidre marked an inline comment as done.

Revision Contents
Changeset List

PathPackages
Msrc/Gui/KSMainWindow.cpp (3 lines)

Diff 58617

View Options

src/Gui/KSMainWindow.cpp

Loading...