Differential D2137

Fix warning in BasicListItem.width
AbandonedPublic
Actions

Authored by apol on Jul 11 2016, 4:28 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Summary

.../org/kde/kirigami/GlobalDrawer.qml:360:25: QML BasicListItem: Binding
loop detected for property "width"
Don't explicitly make sure that the width will be the same as the parent,
instead only do it if it's in a layout.

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol updated this revision to Diff 5078.Jul 11 2016, 4:28 PM
apol retitled this revision from to Fix warning in BasicListItem.width.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami. · View Herald TranscriptJul 11 2016, 4:28 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added inline comments.Jul 11 2016, 5:32 PM
src/controls/templates/AbstractListItem.qml
123

this would work only for items in a ColumnLayout?

apol abandoned this revision.Jul 12 2016, 2:17 PM

Revision Contents
Changeset List

Diff 5078

View Options

src/controls/templates/AbstractListItem.qml

Loading...