[platforms/fbdev] Properly detect a BGR image format
ClosedPublic
Actions

Authored by graesslin on Jul 11 2016, 8:56 AM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

R108:aaf8ce16dfb2: [platforms/fbdev] Properly detect a BGR image format

Summary

If the format of the framebuffer is BGR we cannot create an RGB image
format from it - the rendering is incorrect. Unfortunately QImage does
not support a BGR image format.

To solve this problem we still use an RGB image format but on rendering
the front buffer is rgbSwapped to convert the RGB image to a BGR image.

BUG: 365243
FIXED-IN: 5.7.1

Test Plan

No way to test this on my system

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 5072.Jul 11 2016, 8:56 AM

graesslin retitled this revision from to [platforms/fbdev] Properly detect a BGR image format.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma on Wayland.

Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJul 11 2016, 8:56 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

Called the initFormat in wrong place. Now also tested on a neon vm image

sebas accepted this revision.Jul 12 2016, 10:58 PM

sebas added a reviewer: sebas.

This revision is now accepted and ready to land.Jul 12 2016, 10:58 PM

Closed by commit R108:aaf8ce16dfb2: [platforms/fbdev] Properly detect a BGR image format (authored by graesslin). · Explain WhyJul 13 2016, 7:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/platforms/fbdev/fb_backend.h (9 lines)
M			plugins/platforms/fbdev/fb_backend.cpp (16 lines)
M			plugins/platforms/fbdev/scene_qpainter_fb_backend.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5072	62d09fa		Jul 11 2016, 8:56 AM	★	★
Diff 2	5098	62d09fa	Called the initFormat in wrong place. Now also tested on a neon vm image	Jul 12 2016, 2:14 PM	★	★
Diff 3	5108	6617484	rKWINaaf8ce16dfb258a48ea25209b6747f5d9f5a85b6	Jul 13 2016, 7:37 AM	★	★