Fix FakeAkonadiServerCommands being leaked
ClosedPublic

Authored by dfaure on May 11 2019, 9:26 AM.

Details

Summary

Porting to unique_ptr would be complex here because each command
goes through the following containers, between creation and usage+deletion:

  • QList<FakeJobResponse *>
  • QList<FakeAkonadiServerCommand *>
  • QQueue<FakeAkonadiServerCommand *>
Test Plan

tagmodeltest with ASAN (but it has other leaks)

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure requested review of this revision.May 11 2019, 9:26 AM
dfaure created this revision.
dvratil accepted this revision.May 13 2019, 10:24 AM
This revision is now accepted and ready to land.May 13 2019, 10:24 AM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 13 2019, 4:10 PM