Use kcoreaddons_add_plugin function to install plugins
ClosedPublic
Actions

Authored by elvisangelaccio on Jul 7 2016, 2:44 PM.

Details

Reviewers

Commits

R36:5d133a923cbc: Port to kcoreaddons_add_plugin

Summary

KCoreAddons provides this handy macro to install plugins. It's useful to
simplify the plugin handling in the cmake files. We can also define a
kerfuffle_add_plugin wrapper for the kerfuffle plugins.

Diff Detail

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio updated this revision to Diff 5007.Jul 7 2016, 2:44 PM

elvisangelaccio retitled this revision from to Use kcoreaddons_add_plugin function to install plugins.

elvisangelaccio updated this object.

elvisangelaccio added a reviewer: rthomsen.

Restricted Application added a project: Ark. · View Herald TranscriptJul 7 2016, 2:44 PM

Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript

Very nice! Ship it! :)

This revision is now accepted and ready to land.Jul 7 2016, 4:29 PM

Closed by commit R36:5d133a923cbc: Port to kcoreaddons_add_plugin (authored by elvisangelaccio). · Explain WhyJul 7 2016, 5:03 PM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in R36:5d133a923cbc: Port to kcoreaddons_add_plugin.

Revision Contents
Changeset List

			Path	Packages
M			app/CMakeLists.txt (6 lines)
M			plugins/CMakeLists.txt (7 lines)
M			plugins/cli7zplugin/CMakeLists.txt (9 lines)
M			plugins/cliplugin-example/CMakeLists.txt (6 lines)
M			plugins/clirarplugin/CMakeLists.txt (7 lines)
M			plugins/cliunarchiverplugin/CMakeLists.txt (7 lines)
M			plugins/clizipplugin/CMakeLists.txt (6 lines)
M			plugins/libarchive/CMakeLists.txt (11 lines)
M			plugins/libsinglefileplugin/CMakeLists.txt (28 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5007	13721e2		Jul 7 2016, 2:44 PM	★	★
Diff 2	5009	13721e2	rARK5d133a923cbcc5a80eb48d1d81cc4072de22f826	Jul 7 2016, 4:51 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
ed5226ed3fed	f61e92b4420b	f5cfc9c00d10	Elvis Angelaccio	Don't bother with JSON parameter	Jul 7 2016, 2:41 PM
f5cfc9c00d10	ecbdeef131bb	13721e2a673a	Elvis Angelaccio	Use kcoreaddons_add_plugin function	Jul 7 2016, 2:34 PM