Forward DelegateRecycler keyboard events to the actual delegate.
Have PrivateActionToolButton trigger its action if the mnemonic is activated.
BUG: 403711
Details
Details
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11731 Build 11749: arc lint + arc unit
| src/controls/private/PrivateActionToolButton.qml | ||
|---|---|---|
| 100 ↗ | (On Diff #57865) | why p0? having another shortcut here isn't nice, but is kinda necessary since how the desktop style paints the text in the button background just remove p0 |
| src/delegaterecycler.cpp | ||
| 373 ↗ | (On Diff #57865) | this doesn't look right. especially because it will help with keyboard navigation, but not with accessibility at all. The proper solutuion should be make DelegateRecycler a FocusScope (and i *think* setting activefocusontab to false tough not 100% sure now) |
| src/delegaterecycler.cpp | ||
|---|---|---|
| 373 ↗ | (On Diff #57865) | DelegateRecycler can't be a FocusScope itself because QQuickFocusScope is private API. We could put it in a FocusScope but then this opens a can of worms WRT sizes. |
| src/delegaterecycler.cpp | ||
|---|---|---|
| 373 ↗ | (On Diff #57865) | https://doc.qt.io/qt-5/qquickitem.html#Flag-enum you can set the focusscope flag on top of any qquickitem, FocusScope is just an empty item that doesn't do anything that setting thjat flag in its ctor QQuickFocusScope::QQuickFocusScope(QQuickItem *parent) setFlag(ItemIsFocusScope); } |
| src/delegaterecycler.cpp | ||
|---|---|---|
| 373 ↗ | (On Diff #57865) | I tried it, but it doesn't really make a difference, since the event was already being delivered to the item, the recycler, the problem was that the key stroke never reached the actual delegate. I've changed it to use the declarative API, I think it looks more elegant. |