Differential D21071

Use https links where available
ClosedPublic
Actions

Authored by vkrause on May 7 2019, 4:27 PM.

Tags

Subscribers

dvratil, kde-pim

Details

Reviewers

Commits

R180:7a884572909b: Use https links where available

Diff Detail

Repository

R180 PIM: KMime

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.May 7 2019, 4:27 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 7 2019, 4:27 PM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

vkrause requested review of this revision.May 7 2019, 4:27 PM

Harbormaster completed remote builds in B11644: Diff 57727.May 7 2019, 4:27 PM

The broken apidox links should probably be fixed and redirected to HTTPS as well.

README.md
16	Also doesn't work.
837	This link doesn't work even in HTTP version :(

This revision now requires changes to proceed.May 7 2019, 4:52 PM

vkrause added inline comments.May 7 2019, 5:01 PM

README.md
16	Yep, the two messagelib API docs link are broken. The problem is that the API docs generation for master is currently broken (see https://api.kde.org/logs/api/frameworks/frameworks5.log), so we currently don't have the link target for this available, sysadmins are working on it.

I see, I wasn't aware of that. Let's ignore that for now, then :)

This revision is now accepted and ready to land.May 7 2019, 5:02 PM

Closed by commit R180:7a884572909b: Use https links where available (authored by vkrause). · Explain WhyMay 8 2019, 6:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			README.md (100 lines)
M			autotests/headertest.cpp (2 lines)
M			src/kmime_contentindex.h (2 lines)
M			src/kmime_dateformatter.h (4 lines)
M			src/kmime_mdn.h (2 lines)
M			src/kmime_util.h (2 lines)

Diff 57773

README.md

Loading...

autotests/headertest.cpp

Loading...

src/kmime_contentindex.h

Loading...

src/kmime_dateformatter.h

Loading...

src/kmime_mdn.h

Loading...

src/kmime_util.h

Loading...