Remove method declaration with missing implementation
ClosedPublic
Actions

Authored by hriesenbeck on May 6 2019, 7:04 PM.

Details

Reviewers

Group Reviewers

Summary

The setTranslation(int index, KEduVocTranslation *translation) method of
class KEduVocExpression have declaration but no implementation. The
declaration is removed.

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

hriesenbeck created this revision.May 6 2019, 7:04 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 6 2019, 7:04 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

hriesenbeck requested review of this revision.May 6 2019, 7:04 PM

Harbormaster completed remote builds in B11611: Diff 57679.May 6 2019, 7:04 PM

hriesenbeck added a reviewer: KDE Edu.May 6 2019, 7:11 PM

Do you think we'll need this method?

Otherwise since it's clearly not being used we could just remove it?

I agree with you, that this method can be removed.
So I will modify the review accordingly.

hriesenbeck retitled this revision from Missing Implementation for KEduVocExpression method is added to Remove method declaration with missing implementation.May 21 2019, 2:25 PM

hriesenbeck edited the summary of this revision. (Show Details)

hriesenbeck edited the test plan for this revision. (Show Details)

The previous made changes are reverted and the faulty method declaration is removed.

Your diff is a bit weird it removes code that doesn't exist.

Anyhow i'll remove the function declaration myself and pretend you did it :D

This revision is now accepted and ready to land.May 21 2019, 8:03 PM

https://cgit.kde.org/libkeduvocdocument.git/commit/?id=f21e006a12071d0e29cb06efa79d97ddb9bf9fcf

Revision Contents
Changeset List

		Path
M		keduvocdocument/autotests/CMakeLists.txt (1 line)
D	M	keduvocdocument/autotests/keduvocexpressiontest.h (43 lines)
D	M	keduvocdocument/autotests/keduvocexpressiontest.cpp (37 lines)
M		keduvocdocument/keduvocexpression.h (7 lines)
M		keduvocdocument/keduvocexpression.cpp (12 lines)