Differential D2104

[Task Manager] Close gap when there is no icon
AbandonedPublic
Actions

Authored by broulik on Jul 6 2016, 3:08 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Summary

In case there is no icon for an application, don't display an empty gap

Test Plan

Apparently we don't have the useless X fallback icon anymore but now we have a gap instead. This patch closes it, looks nice.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 4985.Jul 6 2016, 3:08 PM
broulik retitled this revision from to [Task Manager] Close gap when there is no icon.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 6 2016, 3:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein edited edge metadata.Jul 6 2016, 4:47 PM

Thanks for this patch, but I'm curious to investigate the underlying reason. libtaskmanager should actually try to procure a fallback icon and the TM applet should never end up seeing an invalid icon. Do you have an app I can reproduce this with?

We might still end up applying this -- but I want to get to the bottom of it first.

hein accepted this revision.Jul 7 2016, 11:15 PM
hein edited edge metadata.

I'm still going to investigate this a bit more next week, but in the meantime this patch by itself is OK :)

This revision is now accepted and ready to land.Jul 7 2016, 11:15 PM
broulik abandoned this revision.Mar 27 2017, 5:14 PM

Revision Contents
Changeset List

Diff 4985

View Options

applets/taskmanager/package/contents/ui/Task.qml

Loading...