Differential D20988

Move PimCommon::GenericGrantleeFormatter here
ClosedPublic
Actions

Authored by vkrause on May 3 2019, 4:03 PM.

Details

Reviewers
dvratil
Commits
R77:9b1caeec4a94: Move PimCommon::GenericGrantleeFormatter here
Summary

This allows us to use the i18n and icon loading integration in there.
Apart from adding that, there have been small API cleanups (such as no
longer inheriting from QObject) since we need to adjust all users anyway
now.

Diff Detail

Repository
R77 PIM: Grantlee Theme
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.May 3 2019, 4:03 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 3 2019, 4:03 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.May 3 2019, 4:03 PM
dvratil accepted this revision.May 4 2019, 7:24 AM
This revision is now accepted and ready to land.May 4 2019, 7:24 AM
Closed by commit R77:9b1caeec4a94: Move PimCommon::GenericGrantleeFormatter here (authored by vkrause). · Explain WhyMay 4 2019, 8:56 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 57525