[System Tray] Increase maximum icon size
ClosedPublic

Authored by broulik on Jul 6 2016, 8:51 AM.

Details

Summary

BUG: 364431
FIXED-IN: 5.7.1

Test Plan

My systray icons now have the same size they had before updating to Plasma 5.7.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 4973.Jul 6 2016, 8:51 AM
broulik retitled this revision from to [System Tray] Fix icon size.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 6 2016, 8:51 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a subscriber: mart.Jul 6 2016, 9:02 AM

so they leak out from the panel now?

Why would they leak out of the panel? We still have Math.min(width, height).

I cannot even make my panel tiny enough for that to happen.

mart added a comment.Jul 6 2016, 9:05 AM

if the panel height is less than smallmedium, Math.max(Math.min(width, height), units.iconSizes.smallMedium) will get a size bigger than the panel itself

broulik updated this revision to Diff 4974.Jul 6 2016, 9:10 AM
broulik retitled this revision from [System Tray] Fix icon size to [System Tray] Increase maximum icon size.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
mart accepted this revision.Jul 6 2016, 9:26 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jul 6 2016, 9:26 AM
This revision was automatically updated to reflect the committed changes.